re-assigning worker_extra_args instead of altering it with +=#591
Merged
Conversation
guillaumeeb
approved these changes
Oct 3, 2022
Contributor
Author
|
@guillaumeeb , a bit of a silly request: Would you mind adding a label |
Member
|
I created a new label, is this OK? |
Contributor
Author
|
@guillaumeeb perfect, thanks! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
worker_extra_argsis assigned to a config value. With+=the config value is changed every time, so the args will be appended again for each job resulting in #589.It's a regression from #576.
Fixes #589
CC @guillaumeeb @theXYZT